#tyndur · 2009-08-15
170 Nachrichten · Seite 1 von 1 · Original-CSV herunterladen
- taljethMoin
- FreakyPenguinMoin
- taljethMoin FreakyPenguin
- taljethFreakyPenguin: Are you ok with my changes to the logs page?
- FreakyPenguinDoesn't look too bad ;-)
- taljethKonqueror doesn't render the border for the <select>. KRITIKEL! ;-)
- FreakyPenguinWell... fix it! ;-)
- taljethMaybe when you have finished porting KDE to tyndur :-P
- FreakyPenguinBut that's okay for me, as long as w3m renders it properly. ;-)
- taljeth*hehe*
- taljethHm, is there anything useful to do? I definitely don't feel like fixing the git port...
- pcmattmanHmm, trying to run my module... I get "Befehl wurde nicht gefunden"
- taljethWhich is "command not found" as you probably have guessed
- taljethDoes the file exist?
- pcmattmanHmm, it does
- pcmattmanBut I'm using a US keyboard layout, so I need to use SHIFT-7 to get a proper slash... Oops :)
- taljethHeh, you'll not only learn the German language but also the German keyboard layout, it seems ;-)
- SHyx0rmZhello
- taljethHi SHyx0rmZ
- FreakyPenguintaljeth: What about documenting cdi? I dont feel like debugging ata on lio2 neither... ;-)
- taljethpcmattman: Does it work?
- taljethFreakyPenguin: But CDI is perfectly documented already? ;-)
- taljethIs the current LIOv2 code in the git?
- pcmattmantaljeth: It does. Now I just need to write the driver... :)
- FreakyPenguin*g*
- taljethpcmattman: Sounds like the easy part ;-)
- pcmattmanHalfway through device initialisation now, so I'm making good time :)
- FreakyPenguintaljeth: I don't think I commited the kernel ata already...
- FreakyPenguinBut I think I could change that. ;-)
- taljethRight, last commit is from the last day of hackathon
- pcmattmanBack soon, dinner :)
- taljethGuten Appetit (don't think that exists in English?)
- FreakyPenguintaljeth: Now I've pushed some changes. I hope it compiles... ;-)
- FreakyPenguinWith this code I'm able to mount ext2, but the root dir stays empty. iirc ext2 doesnt get correct data when it tries to read the root inode.
- taljethWhich means that you'd better use some simpler tests
- taljethFreakyPenguin: Do you have any plans what to do with the comments in CDI driver code, regarding their language?
- taljethI guess we can have the public headers multilingual, just like bluecode does in his C++ library. But for inline comments this feels ridiculous.
- FreakyPenguinSo there's only one option I think...
- taljethpcmattman: Or how do you feel about it?
- taljethI suspect a standard containing "The driver author SHALL learn German" isn't a solution ;-)
- FreakyPenguinBilingual headers would be nice, if we can keep the comments in sync... ;-)
- pcmattmanI think driver code can be in whatever language, as the idea is that drivers shouldn't need edits to be ported
- taljethI think we can. pcmattman just need to add his NACK to each patch modifying the German version, but not the English one ;-)
- taljethpcmattman: In general, yes. But let's take your floppy driver patch as an example. Should I translate your additional comments? Having mixed-language comments seems the worst of all options to me.
- pcmattmanI would say each driver would have a specific language and stick to it
- pcmattmanSo you would probably end up translating my comments
- pcmattmanThe headers though I think should be bilingual, to make it easy for someone who doesn't know German to learn what a function does
- pcmattmanThat's just my 2 cents though
- taljethSure, I couldn't agree more for the headers
- taljethIt should be easy enough to even strip the "wrong" language when copying the header for a specific OS
- pcmattmanPerhaps
- taljethWould make merging later on more difficult, though
- pcmattmanIdeally though you'd want at least the headers to be directly portable
- pcmattmanThat way porting CDI to a new OS is just implementing functions rather than modifying header files
- taljethYou shouldn't modify the header files ever (except when adding new functions to CDI itself). That I'm doing it all the time is no excuse. ;-)
- FreakyPenguin*g*
- bluecodehi there
- FreakyPenguinHi bluecode
- taljethMoin bluecode
- taljethpcmattman: Btw, I think we still need to find a way to use CDI drivers in Pedigree without patching them. Or have you already managed to do this?
- bluecodewhy do you (have to) patch them for pedigree?
- taljethThe first reason is that I implemented it wrong ;-)
- bluecodewhat specifically?
- taljethThe second is, you need things like MODULE_NAME() and so on in each driver
- bluecodewhich seems like a good idea anyway,doesn't it?
- taljethbluecode: I added a Pedigree specific field to struct cdi_device. Which was okay for a quick hack, but definitely can't stay this way
- taljethbluecode: Agreed. It's just not there yet
- pcmattmantaljeth: I ended up making a "pedigree.cc" file which you add to the driver directory and modify to set the right name
- FreakyPenguinI just added a cdi-devel list to list.tyndur.org. Hope it works ;-)
- taljethDo I need to subscribe myself or have already subscribed a standard set of interested people? ;-)
- FreakyPenguinNo, till now I don't have chosen any volunteers ;-)
- FreakyPenguinOkay, you are subscribed
- bluecodepcmattman: what C++ classes are allowed to be used in pedigree modules? Nothing from the standard library, right?
- pcmattmanbluecode: The full kernel functionality is exposed to modules, but no standard libraries
- taljethWhich reminds me that we need to get rid of the printfs in drivers
- bluecodepcmattman: so there is probably not much ground for a C++ interface to/for CDI...
- pcmattmanNot unless we ported the STL to Pedigree kernel space...
- taljethbluecode: You need volunteers to help you with the lightOS CDI interface? ;-)
- bluecodeyou mean implementing CDI for lightOS?
- bluecodeor a C++ interface?
- taljethThe C++ interface that you're probably going to use for implementing CDI for lightOS?
- bluecodeI don't think I need C++ to implement the CDI stuff
- taljethThen I guess my assumption was wrong
- bluecodewhat's backdev in struct cdi_device for?
- taljethSomething with ATAPI
- taljethI think the block driver uses this to reference the SCSI driver or something like that
- bluecodewhy is it tyndur-specific then?
- bluecodeat least it says so in the comment
- taljethI guess because nobody cared to standardize it ;-)
- taljethjanosch had a different implementation of ATAPI, more or less outside CDI
- taljethFreakyPenguin: You should have some ne2k hardware around, right?
- bluecodeshould it be permittet to write a driver in C++ (only calling the current CDI functionality)?
- FreakyPenguintaljeth: ISA?
- taljethPCI
- FreakyPenguinI dont think so...
- bluecodebochs has one
- pcmattmanPCI
- bluecodebut tyndur on bochs is fun *g*
- taljethqemu has one, too
- taljethBut real hardware usually behaves differently
- bluecodesure
- taljethAs your pcnet driver proves ;-)
- FreakyPenguinI have a bunch of ne2k ISA, but I dont think I have any pci-versions of them ;-)
- taljethHm, ok. stultus might have one
- taljethAt least he has a 3c90x for the next driver ;-)
- bluecodeI asked the question cause extern "C" might be missing
- pcmattman#ifdef __cplusplus extern"C" {..... is missing from all the headers
- bluecodeexactly
- pcmattmanThat's not a difficult change though
- bluecodeof couse not, I am just asking if it is supposed to be there
- taljethI'm not exactly thrilled about C++ drivers. You wouldn't want Pascal drivers either. But if it helps in any way I wouldn't oppose the change.
- taljethI guess it helps when writing the OS specific CDI implementation, too, so it would make sense
- taljeth(und sogar welchen ergeben *g*)
- FreakyPenguin*g*
- bluecodeI am not going to giggle over this, language nazi ;-)
- taljethThose Germans don't have any humour *sigh* ;-)
- bluecodeof course not!
- bluecodeshould I send a patch with the extern stuff?
- taljethI don't need it, but you and pcmattman might profit. Feel free.
- cwo_pengen_Gtuanheh nice software here http://www.sharehaha.com/download.php?id=5C804A041
- taljethpcmattman: You definitely need an editor that highlights trailing whitespace ;-)
- pcmattman:(
- pcmattmanOne day I'll create a patch that is correct the first time. That'll be a good day.
- FreakyPenguin*g*
- taljethHeh, we'll see. ;-)
- taljethNo need to resend, though, I can fix it myself
- taljeth|ne2kSeems to work so far
- FreakyPenguinNice :)
- taljethAnyone feeling like reviewing the code? ;-)
- pcmattmanHmm, internet dropped out...
- taljethHope you're not using our network drivers ;-)
- pcmattmanHehe, just Windows drivers :P
- taljethHm, is the tyndur coding style applicable to CDI drivers?
- FreakyPenguinI think this should be defined for each driver...
- pcmattmanI tried to uphold the coding style used by the RTL8139 driver
- taljethIt's only minor details like the space after if or uint16_t* foo vs. uint16_t *foo
- taljethI think I'll just commit it as is
- taljethWe already have janosch's code and it deviates from our coding style much more
- taljethpcmattman: I'm wondering... You haven't complained one single time about aynthing in CDI now. Is it so easy or are you just being polite? ;-)
- pcmattmanI honestly have not had a problem with it so far
- FreakyPenguinSo you didn't use cdi/fs, right? *g*
- pcmattmanHehe, correct
- taljethHeh, right. I prefer not to touch cdi/fs if it can be avoided.
- pcmattmanWe already have FAT, ext2, and ISO9660 drivers. So I didn't really think much about cdi/fs
- taljethThere's probably no point in it then
- taljethAt least as long as nobody starts to write a btrfs driver or so
- taljethOr maybe NTFS
- pcmattmanIf there ends up a CDI NTFS driver, I'll probably end up putting cdi/fs stuff into Pedigree :)
- taljethWell, I don't think I'm going to write one. I don't have any NTFS partitions.
- taljethAre you going to go beyond network drivers and floppy for CDI in Pedigree?
- taljethI'm thinking of planned things like USB, sound or video (well, for the latter James have already stated that you are going to do your own thing)
- pcmattmanUSB we already have code that's going to be reviewed and integrated soon
- pcmattmanBut definitely sound, if it has a good interface
- taljethWe need to define it yet
- pcmattmanYup
- taljethWith USB, looks like bad timing :-(
- pcmattmanAdditionally we want to tackle USB with C++, because our design of the driver(s) shows that there's a clean inheritance pattern
- FreakyPenguinWell, you can do inheritance with C too. *g*
- pcmattmanI don't believe in trying to use object-oriented practices in non-object-oriented languages :)
- pcmattmanLots of people disagree with me, but that's just how I see it
- taljethBasically you're disagreeing with CDI then
- pcmattmanPerhaps
- pcmattmanI might rephrase...
- pcmattmanI don't believe in trying to use *excessive* object-oriented practices in non-oo languages
- taljeth*g*
- pcmattmanI don't like seeing projects where they *clearly* should be using C++
- taljethIt's always the question where you draw the line
- pcmattmanAnyway, I'm going to sleep now. Night all
- FreakyPenguingn8 pcmattman
- taljethgn8