#tyndur · 2009-08-22

65 Nachrichten · Seite 1 von 1 · Original-CSV herunterladen

  1. taljethMoin
  2. FreakyPenguinMoin
  3. taljethMoin FreakyPenguin, XanClic
  4. XanClicGood morning, FreakyPenguin, taljeth
  5. XanClicI am on it ;-)
  6. XanClicI have already found two mistakes ;-)
  7. taljethIt was late...
  8. XanClicBut the second one was none *g*
  9. taljethHeh. It's not that easy. My mistakes are more subtle. ;-)
  10. XanClicImagined that.
  11. taljethThough I already knew that something was wrong, it's doesn't work this way. Just thought you'd tell me what it is. ;-)
  12. taljeth-'s
  13. taljethXanClic: Fixed and pushed
  14. XanClicHave you tested it?
  15. taljethOnly ls, but seems this was the bug
  16. taljethI'm wondering why there are cdi_sleep_ms calls in msd.c. Shouldn't this lowlevel stuff be handled by the UHCI driver?
  17. XanClicIf you send a "read" command, the device must read the data first before it can send it, I think - you may try the stuff without sleeping, if you want to, I haven't done yet ;-)
  18. taljethI guess you get away with no waiting at all in qemu
  19. taljethSo this isn't a valid test case
  20. taljethDoes the driver even run on real hardware now?
  21. XanClicIt runs under Paloxena ;-)
  22. XanClicHaven't tried it on týndur for a week - it takes so much time to copy the image to the hard disk
  23. taljethRuns? On tyndur it's more like creeping. ;-)
  24. XanClic*g*
  25. taljethHuh? cp isn't really that difficult...
  26. taljethAnyway, even if the sleeps are necessary, conceptually they belong to the hardware driver, not to the user (which is msd)
  27. taljethmsd is doing way too much lowlevel stuff, imho
  28. XanClicBut if any driver knew how long to sleep, it would be the MSC driver, I think
  29. XanClicHm, maybe you get a NAK, if the data is not already there...
  30. XanClicI think, that's it. I have a book about USB here and it says: "Wenn die Function nicht in der Lage ist, Daten zu liefern, wird statt der Datenphase ein NAK-Handshake an den Host gesendet. Dies informiert den Host darüber, dass die Function noch nicht bereit ist, neue Daten zu senden. Dies ist kein Fehler, sondern dient der normalen Ablaufkontrolle bei Interrupt-, Bulk- und Control-Transfer."
  31. XanClicThat was a quotation, hence I did not translate it ;-)
  32. taljethIs this msd specific or generic USB functionality?
  33. XanClicGeneric USB
  34. taljethGreat. Let's do it in main.c or uhci.c then
  35. taljethmsd needs to be as dumb as possible
  36. XanClicOK.
  37. taljethI guess things like write_cmd or read_status are generic as well
  38. XanClicI like your patch very well, don't worry ;-)
  39. taljethActually, it seems we don't even want to have a read_status that returns a complete struct, but more something like a bool usb_is_success()
  40. XanClicThat's right
  41. taljethCare to do some of the refactoring or do you prefer me to do it?
  42. XanClicI do it and you fix it, OK? *g*
  43. taljethGo ahead ;-)
  44. XanClicHm, it's not that faster without sleep and with NAK handling
  45. taljethI wouldn't have it expected to be faster
  46. taljethIt results in much cleaner code, though
  47. XanClicBut I hoped it would be faster, too ;-)
  48. taljethHm... Is there a patch that I missed? ;-)
  49. XanClicNo, it isn't ;-)
  50. taljethSo it's only complete enough to know that it's still slow, but not complete enough for sending to the ML?
  51. XanClicI'm entering the commit message right now ;-)
  52. taljethHuch... "From: Max Reitz <max@??yndur.org>"
  53. XanClicHm...
  54. XanClicI sent it via send-email ;-)
  55. taljethI think it just uses whatever format-patch generates
  56. XanClicI think it uses the stuff after "--from"
  57. XanClicAnd I typed "--from max@tyndur.org"
  58. XanClicBut I see it here, too...
  59. XanClicArgh.
  60. XanClicDead keys are NOT ftw.
  61. taljethLeave it out next time. send-email figures it out from the patch header by itself.
  62. taljethNo need for --from
  63. XanClicI set my mail address to "max@ŧyndur.org"... ><
  64. XanClicSee the "ŧ"?
  65. taljethNice domain. ;-)