#tyndur · 2010-03-17
30 Nachrichten · Seite 1 von 1 · Original-CSV herunterladen
- kwolfMoin
- pcmattmanHi kwolf
- kwolfYay, pcmattman is back! :-)
- pcmattmanI am :)
- kwolfNow if I only could remember my questions about the e1000 patch. I should have written a mail.
- kwolfOne thing was e1000_reg_read/write... Is it a useless wrapper or is it black magic? ;-)
- pcmattmanUseless wrapper, can be removed
- pcmattmanI realised after I sent the mail how useless the functions actually were :)
- kwolfAh, good. I was thinking of some strange optimisation things going on or something like that.
- kwolfAnd what does this write_flush thing do exactly? Is it just a delay or are there some other implications?
- pcmattmanBasically reads from the status register on the device, which ensures the write completes
- pcmattmanIf nothing else it's a wait for an I/O cycle
- kwolfSo you don't know exactly yourself? ;-)
- pcmattmanI just explained it
- kwolfSorry, read that wrong
- pcmattmanThat's okay, I can see how it might have come across as not knowing for certain
- kwolfWe should switch to German, I'm less likely to misunderstand things then ;-)
- pcmattmanI'm more likely to not understand at all :P
- kwolfAnyway, what do think about moving the EEPROM stuff into its own file for v2 of the patch?
- kwolfpcmattman: Well, you can have everything ;-)
- kwolf*can't
- pcmattmanWell, most other drivers seem to do that
- pcmattmanI think it's a good idea to start modularising the driver, especially if multiple chips are going to be supported
- kwolfI agree
- kwolfAnd then, I can't remember what it was exactly, but compiling the code under Linux gave me a warning
- kwolfI think with these changes were ready for v2
- kwolfMaybe some comments, but on the other hand we don't want to copy the spec
- pcmattmanYup, I'll look at getting v2 done and sent this week
- kwolfSounds good :-)
- pcmattmanNight