#tyndur · 2010-03-17

30 Nachrichten · Seite 1 von 1 · Original-CSV herunterladen

  1. kwolfMoin
  2. pcmattmanHi kwolf
  3. kwolfYay, pcmattman is back! :-)
  4. pcmattmanI am :)
  5. kwolfNow if I only could remember my questions about the e1000 patch. I should have written a mail.
  6. kwolfOne thing was e1000_reg_read/write... Is it a useless wrapper or is it black magic? ;-)
  7. pcmattmanUseless wrapper, can be removed
  8. pcmattmanI realised after I sent the mail how useless the functions actually were :)
  9. kwolfAh, good. I was thinking of some strange optimisation things going on or something like that.
  10. kwolfAnd what does this write_flush thing do exactly? Is it just a delay or are there some other implications?
  11. pcmattmanBasically reads from the status register on the device, which ensures the write completes
  12. pcmattmanIf nothing else it's a wait for an I/O cycle
  13. kwolfSo you don't know exactly yourself? ;-)
  14. pcmattmanI just explained it
  15. kwolfSorry, read that wrong
  16. pcmattmanThat's okay, I can see how it might have come across as not knowing for certain
  17. kwolfWe should switch to German, I'm less likely to misunderstand things then ;-)
  18. pcmattmanI'm more likely to not understand at all :P
  19. kwolfAnyway, what do think about moving the EEPROM stuff into its own file for v2 of the patch?
  20. kwolfpcmattman: Well, you can have everything ;-)
  21. kwolf*can't
  22. pcmattmanWell, most other drivers seem to do that
  23. pcmattmanI think it's a good idea to start modularising the driver, especially if multiple chips are going to be supported
  24. kwolfI agree
  25. kwolfAnd then, I can't remember what it was exactly, but compiling the code under Linux gave me a warning
  26. kwolfI think with these changes were ready for v2
  27. kwolfMaybe some comments, but on the other hand we don't want to copy the spec
  28. pcmattmanYup, I'll look at getting v2 done and sent this week
  29. kwolfSounds good :-)
  30. pcmattmanNight