Delivered-To: mlmmj-tyndur-devel
Received: from sv1.famkaufmann.info [176.9.73.67]
	by 57269a166aaa with IMAP (fetchmail-6.3.26)
	for <mlmmj@localhost> (single-drop); Tue, 28 Jan 2020 22:19:34 +0000 (GMT)
Received: from 4e0d9c617c68 ([172.29.0.2])
	by sv1.famkaufmann.info (Dovecot) with LMTP id KYc/G0GzMF6aSQAAM0Xwgw
	for <mlmmj-tyndur-devel>; Tue, 28 Jan 2020 22:18:41 +0000
Delivered-To: tyndur-devel@tyndur.org
Received: from faunus.fritz.box (p200300F3F7228500AFEE4A56EAA43362.dip0.t-ipconnect.de [IPv6:2003:f3:f722:8500:afee:4a56:eaa4:3362])
	by sv1.famkaufmann.info (OpenSMTPD) with ESMTPSA id be78f17f
	TLS version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO
	for <tyndur-devel@tyndur.org>;
	Tue, 28 Jan 2020 22:18:41 +0000 (UTC)
From: Kevin Wolf <kevin@tyndur.org>
To: tyndur-devel@tyndur.org
Subject: [PATCH] libc: stdio_init(): fopen-Modus 's' gibt es nicht
Date: Tue, 28 Jan 2020 23:18:37 +0100
Message-Id: <20200128221837.18470-1-kevin@tyndur.org>
X-Mailer: git-send-email 2.16.4
Errors-To: toni@tyndur.org
Precedence: list
Reply-To: tyndur-Patches <tyndur-devel@tyndur.org>
List-Id: tyndur-Patches <tyndur-devel.tyndur.org>
List-Unsubscribe: <mailto:tyndur-devel+unsubscribe@tyndur.org>
List-Post: <mailto:tyndur-devel@tyndur.org>
List-Help: <mailto:tyndur-devel+help@tyndur.org>
List-Subscribe: <mailto:tyndur-devel+subscribe@tyndur.org>
List-Owner: <mailto:toni@tyndur.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

!  libc: Vor langer Zeit wurde einmal versehentlich in Commit f64c1b3c8
   ein fopen-Modus 's' committet, der IO_OPEN_MODE_SYNC gesetzt hat (das
   aber wiederum ignoriert wird), am Tag danach aber in Commit 95134b9a0
   wieder revertet. Davor und danach war es immer ein ungültiger Modus.

   Bevor fopen() jetzt anfangen kann, zu prüfen, ob es den übergebenen
   Modus überhaupt komplett versteht, muss zuerst das ungültige 's' in
   stdio_init() weg.

Signed-off-by: Kevin Wolf <kevin@tyndur.org>
---
 src/modules/lib/stdlibc/stdio.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/modules/lib/stdlibc/stdio.c b/src/modules/lib/stdlibc/stdio.c
index 7e0766f40..1bbad8dfd 100644
--- a/src/modules/lib/stdlibc/stdio.c
+++ b/src/modules/lib/stdlibc/stdio.c
@@ -61,12 +61,12 @@ void stdio_init(void)
             size = fread(path, 1, 128, path_file);
             path[size] = 0;
 
-            // Falls stdin schon geoeffnet wurde, wird freopen benutzt, damit siche
-            // nichts durcheinander kommt
+            // Falls stdin schon geoeffnet wurde, wird freopen benutzt, damit
+            // sicher nichts durcheinander kommt
             if (stdin) {
-                freopen(path, "rs", stdin);
+                freopen(path, "r", stdin);
             } else {
-                stdin  = fopen(path,  "rs");
+                stdin  = fopen(path,  "r");
             }
             fclose(path_file);
         }
-- 
2.16.4

