Delivered-To: mlmmj-tyndur-devel
Received: from sv1.famkaufmann.info [176.9.73.67]
	by a9b8c5461646 with IMAP (fetchmail-6.3.26)
	for <mlmmj@localhost> (single-drop); Thu, 03 Dec 2020 16:23:15 +0000 (GMT)
Received: from localhost ([172.29.0.7])
	by sv1.famkaufmann.info with LMTP
	id +G/qIMgQyV8SbwAALHnFKQ
	(envelope-from <mayerNico@outlook.de>)
	for <mlmmj-tyndur-devel>; Thu, 03 Dec 2020 16:22:32 +0000
Delivered-To: tyndur-devel@tyndur.org
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-oln040092074101.outbound.protection.outlook.com [40.92.74.101])
	by sv1.famkaufmann.info (OpenSMTPD) with ESMTPS id ff7b4b47 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO)
	for <tyndur-devel@tyndur.org>;
	Thu, 3 Dec 2020 16:22:31 +0000 (UTC)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Tw+OLZi63Rxzb7YTcovKzTDYwNVIZcxJMaNHpx2kRAXq3uvg1p1i+mB48r/2gKAb4L9b4O3cz0KBjTDMTkHTY/kj+k6ZxxQd0MWVDwV0ofWckKxuJjr5MQCh36v4aMs3NOUZHXfQWyDeWLy1/52jsPITSwSWgKEGHTuKPE+CLA+FzTQp52rA0qR45njlfCDZyBWRqwNz4xl/9zx0bhaZA9I5hZ5P8hAP796n1H22Q3G8m1V571h9vwuAx+nHZh97cQwfEHSUhV9kFyGwTUeAy4+AZaKfjxcTtupg0RapLg9qX7+0VLtDb4Wgw68gHFSlTcAUX3aGn1VpXOtxWr+fIA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SEd2o9MyLamJoYrShKx+SB6vuZA2iTl79PB+ikG50L8=;
 b=UcqImLO2JN/aBlOTx7tvd0yUTvlYTF1Hnip+ga1VNF9JqLQm9M3F/Fiplb/k/XCAdT/E7y+14khwBfqoyPohiUpI9kqclUP3KN7/ZbyJw95rTIMH/AqjkrcyaUWwHnbZK7wC/dwWxUGPFaw01/FWsc1TzfjVxHALqsIDiImC2IGwSkdLmO7ZJytLC/RxOjtYNKn6WVAdS2AiUwnm5j2ZB5ZHfbD9ngLwgrVa+xu5I59l9DPQ4NpATfVxaNs6vTW1eYYUAT3AZryM2OlDWWbDpiP9wALCF+vPog+9bHX+hSbFtqd+hBnxqLVMwVOLxFAb4fY1IwtsVPFE9V0Xhlrb0A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Received: from HE1EUR04FT040.eop-eur04.prod.protection.outlook.com
 (2a01:111:e400:7e0d::53) by
 HE1EUR04HT234.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0d::419)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17; Thu, 3 Dec
 2020 16:22:30 +0000
Received: from AM8PR04MB7266.eurprd04.prod.outlook.com
 (2a01:111:e400:7e0d::4c) by HE1EUR04FT040.mail.protection.outlook.com
 (2a01:111:e400:7e0d::160) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend
 Transport; Thu, 3 Dec 2020 16:22:29 +0000
X-IncomingTopHeaderMarker:
 OriginalChecksum:1BBE80425549722831EDCC99BB1B0A5444B593FE13485AF1CA6C1FC495117192;UpperCasedChecksum:FE8FCB77376031C4A66BA07792AF9A8DD0670A8087C0FB6622D94510318ECA69;SizeAsReceived:7205;Count:44
Received: from AM8PR04MB7266.eurprd04.prod.outlook.com
 ([fe80::a057:fc9d:dd8d:8540]) by AM8PR04MB7266.eurprd04.prod.outlook.com
 ([fe80::a057:fc9d:dd8d:8540%6]) with mapi id 15.20.3632.018; Thu, 3 Dec 2020
 16:22:29 +0000
From: Nico Mayer <mayerNico@outlook.de>
To: tyndur-devel@tyndur.org
Subject: [PATCH] modules: entfernen von variablen aus den headers
Date: Thu,  3 Dec 2020 17:22:23 +0100
Message-ID:
 <AM8PR04MB7266B4363BB655C9B8BB4166D5F20@AM8PR04MB7266.eurprd04.prod.outlook.com>
X-Mailer: git-send-email 2.28.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-TMN: [nQsPPpFbkaZzM66JKKJ2+O6Ja8WMbIhp]
X-ClientProxiedBy: FR2P281CA0029.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:14::16) To AM8PR04MB7266.eurprd04.prod.outlook.com
 (2603:10a6:20b:1d6::20)
X-Microsoft-Original-Message-ID:
 <20201203162223.114045-1-mayerNico@outlook.de>
Errors-To: toni@tyndur.org
Precedence: list
Reply-To: tyndur-Patches <tyndur-devel@tyndur.org>
List-Id: tyndur-Patches <tyndur-devel.tyndur.org>
List-Unsubscribe: <mailto:tyndur-devel+unsubscribe@tyndur.org>
List-Post: <mailto:tyndur-devel@tyndur.org>
List-Help: <mailto:tyndur-devel+help@tyndur.org>
List-Subscribe: <mailto:tyndur-devel+subscribe@tyndur.org>
List-Owner: <mailto:toni@tyndur.org>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost.localdomain (87.165.248.7) by FR2P281CA0029.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.9 via Frontend Transport; Thu, 3 Dec 2020 16:22:29 +0000
X-MS-PublicTrafficType: Email
X-IncomingHeaderCount: 44
X-EOPAttributedMessage: 0
X-MS-Office365-Filtering-Correlation-Id: 6e516b63-106b-43ef-eb63-08d897a7a175
X-MS-TrafficTypeDiagnostic: HE1EUR04HT234:
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LxvI5vcYxVuUjniPR4fnWRGRpC2TVJUkEtcn3IvJ5QyMk0yGuZeztfb733TACl31Rx2b6tjsB4Ev+MHuHBTNdEpZKP72CfN4BCQEqEginYNUbJUM0uqIx8P05ZOi4znXnLWtEkUjNezfJFOs0ibXpSqZT7WSwkKYWaXPggdUn2vvaiOnPEV4rG10peFaKaF0zzOZK+sVVZUnvcrXRVHwDQ==
X-MS-Exchange-AntiSpam-MessageData:
	+Mxl+c7UeAZZo7gLGLRUEm1Ja/SYtvlyQR+nsiZljOWkBgXv9OWCI/54mPcKZ15yv7R9UQJglFymdTXTKL/fdOn3DkGZW7CVhlDmI4y7MB/wxHYqO6fFsmQ6ay7KP1xFKo+tqzHiYWp/hXTSWGUsjw==
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e516b63-106b-43ef-eb63-08d897a7a175
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2020 16:22:29.8630
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-AuthSource:
	HE1EUR04FT040.eop-eur04.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: Internet
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR04HT234

* In einige Headerfiles wurden globale variablen definiert. Dies ist
eigentlich nicht zulaessig. Stattdessen sollten die globale Variablen
in den Sourcefiles definiert werden.

Signed-off-by: Nico Mayer <mayerNico@outlook.de>
---
 src/modules/c/fdisk/partition.c | 6 ++++++
 src/modules/c/fdisk/partition.h | 4 ++--
 src/modules/cdi/serial/serial.h | 8 ++++----
 3 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/src/modules/c/fdisk/partition.c b/src/modules/c/fdisk/partition.c
index 0ee0645a..10353e8b 100644
--- a/src/modules/c/fdisk/partition.c
+++ b/src/modules/c/fdisk/partition.c
@@ -39,6 +39,12 @@
 #include "partition.h"
 #include "typeids.h"
 
+/// Ein Zeiger auf argv[1] oder besser gesagt den Laufwerksnamen
+char* device_name;
+
+/// Anzahl der Heads
+unsigned long device_numheads;
+
 /// Kopie des MBR
 unsigned char mbr[512];
 
diff --git a/src/modules/c/fdisk/partition.h b/src/modules/c/fdisk/partition.h
index 8955983f..e40b9033 100644
--- a/src/modules/c/fdisk/partition.h
+++ b/src/modules/c/fdisk/partition.h
@@ -56,10 +56,10 @@
 #define PARTITION_TYPE_LOGICAL 2
 
 /// Ein Zeiger auf argv[1] oder besser gesagt den Laufwerksnamen
-char* device_name;
+extern char* device_name;
 
 /// Anzahl der Heads
-unsigned long device_numheads;
+extern unsigned long device_numheads;
 
 /** 
  * Ein einzelner Eintrag der Partitionstabelle, wie er auch auf der Festplatte
diff --git a/src/modules/cdi/serial/serial.h b/src/modules/cdi/serial/serial.h
index 5f9a855d..bf9219a4 100644
--- a/src/modules/cdi/serial/serial.h
+++ b/src/modules/cdi/serial/serial.h
@@ -32,10 +32,10 @@
 #include <stdint.h>
 
 // Basisadressen.
-uint16_t COM1_BASE;
-uint16_t COM2_BASE;
-uint16_t COM3_BASE;
-uint16_t COM4_BASE;
+extern uint16_t COM1_BASE;
+extern uint16_t COM2_BASE;
+extern uint16_t COM3_BASE;
+extern uint16_t COM4_BASE;
 
 // Register-Port-Offsets
 #define REG_TR  0x00 // Bei nicht gesetztem DLAB
-- 
2.28.0

