Delivered-To: mlmmj-tyndur-devel
Received: from sv1.famkaufmann.info [176.9.73.67]
	by a9b8c5461646 with IMAP (fetchmail-6.3.26)
	for <mlmmj@localhost> (single-drop); Thu, 18 Feb 2021 20:04:49 +0000 (GMT)
Received: from localhost ([172.29.0.7])
	by sv1.famkaufmann.info with LMTP
	id IPheOCXILmADEgAALHnFKQ
	(envelope-from <m.nemo@gmx.net>)
	for <mlmmj-tyndur-devel>; Thu, 18 Feb 2021 20:03:49 +0000
Delivered-To: tyndur-devel@tyndur.org
Received: from mout.gmx.net (mout.gmx.net [212.227.17.20])
	by sv1.famkaufmann.info (OpenSMTPD) with ESMTPS id 3cb85bd5 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO)
	for <tyndur-devel@tyndur.org>;
	Thu, 18 Feb 2021 20:03:49 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
	s=badeba3b8450; t=1613678629;
	bh=8iyglFMLGPosgk2YS16+1TUhsWcV//cGj8+itUoLBSM=;
	h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To;
	b=QTST8GXyDmlBkyIgAFPjDYOUP7hzRz5VZxQ1ecC8NXQ4nnxQDFOjTRlQHGyREeiC6
	 XGDjrj944OcgDVR6it1C9KnR3K2FaQVbP5UysZlqS1gK+IE97XIAck/bqkrvyf+9/K
	 5YRvo2wZFujl37AStXrmRqkyl4TTDa7u7zCIgLo0=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from [192.168.178.21] ([79.241.91.106]) by mail.gmx.net (mrgmx105
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mo6qp-1lf3vy0HhD-00pZGi for
 <tyndur-devel@tyndur.org>; Thu, 18 Feb 2021 21:03:49 +0100
Subject: =?UTF-8?Q?Re=3a_=5bPATCH=5d_kernel/syscall=3a_neue_Funktion_f=c3=bc?=
 =?UTF-8?Q?r_das_Registrieren_von_Kernel-Syscalls?=
To: tyndur-devel@tyndur.org
References: <AM8PR04MB72664A9DEA6C41277586F47AD5859@AM8PR04MB7266.eurprd04.prod.outlook.com>
From: MNemo GMX <m.nemo@gmx.net>
Message-ID: <3371fdf3-00d1-0b18-2bb8-691518d2a732@gmx.net>
Date: Thu, 18 Feb 2021 21:03:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
Errors-To: toni@tyndur.org
Precedence: list
Reply-To: tyndur-Patches <tyndur-devel@tyndur.org>
List-Id: tyndur-Patches <tyndur-devel.tyndur.org>
List-Unsubscribe: <mailto:tyndur-devel+unsubscribe@tyndur.org>
List-Post: <mailto:tyndur-devel@tyndur.org>
List-Help: <mailto:tyndur-devel+help@tyndur.org>
List-Subscribe: <mailto:tyndur-devel+subscribe@tyndur.org>
List-Owner: <mailto:toni@tyndur.org>
MIME-Version: 1.0
In-Reply-To: <AM8PR04MB72664A9DEA6C41277586F47AD5859@AM8PR04MB7266.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: de-DE
X-Provags-ID: V03:K1:C+SKLpNt4bbLA5I3vvFImKYIOpv8t3Ug8Nvbc4IS44bPuyjCrvc
 Po0sLBjswuhdW+fyMwFCrZgrCeEz4pIWYPWvKRPd59G02bYk5S1MnWJIzRk8bmNgjKXvp49
 wWJkjTmzbsMgNpBl7bGjAm3cyUsPMYwsDM+xlV0qxe0pSdG3QLbs4lJ/xfL5dtWsNPQs9IW
 qY9iNv760lHC41tqv9anw==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:tgrtkABBmxI=:Tz4fTc4XpzBdOoXxKa9hkR
 YfKF4RxkD6WPLW2UiG4FMeoIII0Y8Nf5nSwhnFO7KU6QrQnlTI69t1TiSqXHldbXHImSqQ1hm
 iFjnl9GdzfsPosJzBvYXoXdazO3HeuoyNkUKojel0VqyJlNI46+g3k78BkZBqZhXNuaZBvr5s
 u6G6qWGn6nS2H5nZJ2tY/6CMH1bhpDdSlpv+eycozPdUyszUreOCKw/HNp73eMMKCw+ka+rsX
 yeUBLXv4aH8VCcwnq9NIua2CtoPNLxlbF9Se5zuL1wUkv3hRk5y6mAEZPvmtkg33vvFSH9cK6
 imDsw43vUasVndliwS9jXpaMZlksEBfViI0l7yVEM1pxVHmXynXKhnO7vQYXpssrNXUeOwkPR
 R8tlI7Z/tUlzDY/fT91YJ//ltHW0YNigQHMMXuSfXF/SPJB9x/9gXgD2ezajhFIHmv2H+224R
 n1DjHLiIIfGR9AuPa5bGKBMayUkEI9Le+kJWBS1i1vj0WCzZWdB3WbCICeDEvJMbvARe6if5x
 BBqG/aKEeTLrZ0jueWGazziCBN/rjspVaoVWuVPDsM0p0PTYHRPTzsCGvmebBPxs3l1r0lFmB
 TF8XrJsxpgpte5vVQ3yDTr3YSSF2pZavAEpmi9OcCtWC8vLaF3gS20riGUZju+4ifteZTvdpm
 E6dn50qa2wrXCMifrK0fa6y48/QleJx5lMVg4XyV2cNDl9tt8WP778Je4qedYK2EofuaE7/6Y
 J45bsQ7OIk0eikMXZsq8nFDZoLs5aq+9QLl6xm0BJNQlTblq4TqHwV0q953HJ0628loQkD7ek
 l5qbmb+ocQuUBjOM6dATR2vT5Q0UmFlKIoFyB4IvbihxHP2WpGaBP7aQ2oAzG947Bj0Dmzu2C
 pQ5jIoITodrguYWwyOAw==

Hi Nico,

On 2/18/21 10:42 AM, Nico Mayer wrote:
> * Aktuell gibt es lediglich einen Kernel-Syscall(KERN_SYSCALL_PM_SLEEP).
> Dieser Syscall wurde bisher manuell in die globale Syscall-Liste
> eingetragen. Um das Registrieren von Kernel-Syscalls zu vereinfachen,
> implementiert dieser Commit die Funktion syscall_register_full().
> ---
>   src/kernel/include/syscall.h |  3 +++
>   src/kernel/src/syscall.c     | 23 ++++++++++++++++++-----
>   2 files changed, 21 insertions(+), 5 deletions(-)
>
> diff --git a/src/kernel/include/syscall.h b/src/kernel/include/syscall.h
> index ad941e85..cd74ac4f 100644
> --- a/src/kernel/include/syscall.h
> +++ b/src/kernel/include/syscall.h
> @@ -70,6 +70,9 @@ void syscall_arch(machine_state_t* isf);
>   /// Einen neuen Syscall verfuegbar machen
>   void syscall_register(syscall_arg_t number, void* handler, size_t arg_=
count);
>
> +/// Einen neuen Syscall verfuegbar machen
> +void syscall_register_full(syscall_arg_t number, void* handler, size_t =
arg_count, bool privileged);
> +
>   /// Syscalls initialisieren
>   void syscall_init(void);
>
> diff --git a/src/kernel/src/syscall.c b/src/kernel/src/syscall.c
> index f74dbebe..2f0274b0 100644
> --- a/src/kernel/src/syscall.c
> +++ b/src/kernel/src/syscall.c
> @@ -151,11 +151,8 @@ void syscall_init()
>       syscall_register(SYSCALL_LIO_SRV_OP_DONE, &syscall_lio_srv_op_done=
, 3);
>       syscall_register(SYSCALL_LIO_SRV_WAIT, &syscall_lio_srv_wait, 0);
>
> -    syscalls[KERN_SYSCALL_PM_SLEEP] =3D (syscall_t) {
> -        .handler    =3D &kern_syscall_pm_sleep,
> -        .arg_count  =3D 2,
> -        .privileged =3D true,
> -    };
> +
> +	syscall_register_full(KERN_SYSCALL_PM_SLEEP, &kern_syscall_pm_sleep, 2=
, true);

Hier ist mit einem TAB einger=C3=BCckt. Bitte einheitlich mit 'SPACES' ein=
r=C3=BCcken.

>   }
>
>   /**
> @@ -178,3 +175,19 @@ void syscall_register(syscall_arg_t number, void* h=
andler, size_t arg_count)
>       syscalls[number].arg_count =3D arg_count;
>       syscalls[number].privileged =3D false;
>   }
> +
> +/**
> + * Einen neuen Syscall registrieren
> + *
> + * @param number Syscallnummer (syscallno.h!)
> + * @param handler Adresse der Handler-Funktion
> + * @param arg_count Anzahl der Argumente, die fuer diesen Syscall ueber=
geben
> + *                  werden muessen.
> + * @param privileged Bei 'true' darf der Syscall nur durch einen
> + *					 Kernel-Thread verwendet werden.
> + */
> +void syscall_register_full(syscall_arg_t number, void* handler, size_t =
arg_count, bool privileged)
> +{
> +	syscall_register(number, handler, arg_count);
> +    syscalls[number].privileged =3D privileged;

Hier auch das Einr=C3=BCcken.

W=C3=BCrde das auch umdrehen. Das die spezielle Funktion die allgemeine au=
fruft

syscall_register(...) -> syscall_register_full(..., false);

> +}

=2D-
Andreas

