#tyndur · 2009-12-09
88 Nachrichten · Seite 1 von 1 · Original-CSV herunterladen
- pcmattmankwolf: Out of interest, when do you expect to have English documentation available for CDI?
- kwolfWhen quok is done ;-)
- pcmattmanIs he doing translation, or are you waiting? :)
- kwolfSeriously, I'm not sure. I don't want to translate comments for things that are going to change anyway
- kwolfHe said he'd start to translate some of them
- pcmattmanTrue
- kwolfWhile he's implementing CDI in his own OS
- pcmattmanIs there anything important I missed while I was away?
- pcmattmanYes, he mentioned that today
- kwolfeddyb somehow stopped to have his monologues and we couldn't figure how to get them back ;-)
- kwolfOtherwise not a lot of important things
- pcmattmanOkay
- kwolfOh, except for the driver initialisation patches, of course
- pcmattmanYes, I noticed them in the list
- kwolfCDI_DRIVER instead of pedigree.cc
- kwolfHope it works out for you
- pcmattmanMuch nicer! :)
- pcmattmanI might have a look at getting that integrated now, actually
- pcmattmankwolf: ping
- kwolfpong
- pcmattmanJust hit a bit of a problem in include/cdi/dma.h
- kwolfUnrelated to the recent changes then?
- pcmattmanYour definition of cdi_dma_handle contains a "FILE*" member, which is not defined
- pcmattmanYes, unrelated
- pcmattmanAt this stage, I am merely going to make an empty struct in Pedigree's cdi-osdep.h, but I thought I would bring it up anyway
- kwolfRight, this belongs into cdi-osdep.h
- kwolfThere even is a comment "LOST-Implementation..."
- pcmattmanYup
- kwolfWhich is (a) the wrong name of the OS and (b) not correct German, because it's correctly called "Implementierung" ;-)
- pcmattmanHehe :)
- pcmattmanIt seems Pedigree also requires specific elements in the structure of dma.h
- pcmattmanI am preparing a set of patches as a result of my recent changes, which should make things a bit neater
- kwolfThanks. I think we really need more cleanup patches in the next time
- pcmattmanWell, re-integrating the latest git CDI into Pedigree shows that kind of thing really well
- kwolfHm... I'm wondering if we need to define struct cdi_dma_handle publicly at all
- kwolfThe interfaces look like it could be completely opaque
- pcmattmanPossibly
- kwolfThe next step I'm going to make in restructuring is to make device creation library driven.
- pcmattmanWhat do you mean by that
- pcmattman?
- kwolfThat is, instead of each driver searching its devices in its init function, I'd prefer to have the CDI library call a probe function
- pcmattmanOh, I see
- kwolfWhich gets the PCI device as a parameter
- kwolfThis will help with hotplugging, which we definitely need as we go forward with USB
- pcmattmanYup
- kwolfMaybe this weekend, don't know. Probably depends on how things are going with our 0.2.2 release
- pcmattmanHmm, kwolf: There's a mismatch between the documentation of CDI_DRIVER and the actual calls in drivers
- kwolfHm
- kwolf?
- pcmattmanThe documentation says "Pointer to a driver description (struct cdi_driver*)" but it's called with a non-pointer object
- kwolfOops. Care to send a patch?
- kwolfThe question is which side to fix. I tend to fixing the comment
- pcmattmanI'll patch the comment
- pcmattmanHowever, I have run into a much bigger problem now
- pcmattmanAt the moment the cdi_*_driver struct is built as a static object, where all of the relocations for init/destroy/init_device/remove_device will happen when the module is loaded
- pcmattmanHowever, because of the way our modules work, we need a const initialiser for each component, which means we can't use a struct
- kwolfWhat you need is a init function, right?
- pcmattmanThat already technically exists, it just can't be specified in a struct
- kwolfYour CDI_DRIVER macro would become ugly, but it could define a wrapper function that accesses the struct
- pcmattmanThat would be a horrendously ugly macro
- pcmattmanI'm working on a possible solution that I'll add as a patch, you can decide if it's okay to keep or not
- kwolfWould it really be horrendously ugly?
- kwolfNot just the usual ugliness with preprocessor magic?
- pcmattmanIn comparison, yes
- pcmattmanAnd I doubt Pedigree is the only OS that will run into such a problem
- kwolfI would have preferred not adding to many (unnamed) parameters to CDI_DRIVER. Not sure if you can find a solution that avoids this
- pcmattmanI have one potential solution, let's see how it goes after I mail the patch to the list
- pcmattmanOkay, the mail is out
- pcmattmanAnd I'm off to sleep, night
- kwolfNicht
- kwolf*Night
- kwolf_Hi quok :-)
- quokHi :)
- FreakyPenguinHi
- XanClicHi
- kwolf_quok: Have you seen Matt's mail, especially his CDI_DRIVER_CONST proposal?
- kwolf_Actually, not only quok, but everyone here
- XanClicSeen: yes; understood: no ;-)
- quokI'm with XanClic on that. I've seen the mail and the diffs, don't really understand the issue though
- kwolf_His problem is that he needs to have something like MODULE_INIT(init_function) for Pedigree
- kwolf_And he can't read the init_function from the driver struct at compile time
- kwolf_I suggested that CDI_DRIVER could generate a static wrapper function that reads it from the struct, but he wasn't quite happy with that
- XanClicSo this CONST macro is just the same as the other macro but you give the content of the driver structure instead of the structure itself?
- kwolf_Right, I think this is what he's intending
- quokCrap, I forgot I have a doctor appointment. I'll bbl. :)
- kwolf_Ok
- DerHartmutGood evening
- XanClicGood evening, DerHartmut