#tyndur · 2009-12-10
60 Nachrichten · Seite 1 von 1 · Original-CSV herunterladen
- pcmattmantaljeth: did you end up getting a chance to review my patch?
- taljethI've had a look, yes, and we started a short discussion but quok had to leave
- pcmattmanAh. I unfortunately lost my backlog from last night, so I wasn't sure what was discussed
- taljethI'm not exactly happy with having CDI_DRIVER_CONST additionally because it's pure code duplication
- taljethSo if anything I'd give up the current CDI_DRIVER completely
- taljethXanClic and quok didn't even understand what your problem is, so no opinion from them yet ;-)
- pcmattmanYou mean, instead of the struct method, just use the explicit definition?
- taljethRight, although I really like doing it with the struct
- taljethBut having two declarations doing the same in each driver is just silly
- pcmattmanWell, the struct is cleaner
- pcmattmanBut it's also a level of indirection, which the compiler errors on in Pedigree modules
- taljethMaybe you can really have a try with the ugly macro? It should work and it's not code that you need to read each day
- pcmattmanI'll see what I can do
- taljethIt's not like I haven't thought about Pedigree. I would have liked to have also the name and the dependencies in the struct only, but this really wouldn't work for you, so I took something in between
- pcmattmanHmm, seems to work better than my original attempt ;)
- taljethWhich one?
- pcmattmanUsing the preprocessor to generate two functions for Pedigree's module code
- pcmattmanIt's also fairly neat, considering it's a preprocessor macro
- taljethRight, it must work good. It's my suggestion. ;-)
- pcmattman:)
- taljethI think it gets a bit uglier if you wanted to compile ata some day because that one defines two drivers in one file
- taljethBut you probably don't need it anyway
- pcmattmanYes, I noticed
- pcmattmanWe have our own ATA code that hooks deeply into the depths of Pedigree ;)
- FreakyPenguinSounds dangerous ;-)
- taljethpcmattman: Yes, we also have our legacy floppy driver ;-)
- pcmattmanThat said, if there is any situation where there ends up being more than one CDI_DRIVER call, I'll need to work some real magic into our CDI_DRIVER definition ;)
- taljethPreprocessor can be real fun if you don't need to do it every day ;-)
- taljeth*Preprocessor magic
- taljethI think basically you would register a module only once and have a second list of all drivers that you need to initialise in your wrapper
- taljethA bit more cumbersome, but still doable
- pcmattmanOkay, patch v2 is sent
- taljethHave you added the extern "C" to all header files now? I think we should it do right at once
- pcmattmanI'll add the remainder now and send as a separate patch
- pcmattmanThen I have to figure out how to call init_device for each driver's devices ;)
- taljethMaybe split your patch and have one patch with all the extern "C"
- taljethAnd another one with cdi-osdep.h
- pcmattmanGood plan
- taljethThe typedefs should at least get a cdi_ prefix. Also, I think in other place we don't have typedefs at all, but use the struct keyword. I won't insist on that, but for consistency it might be worth consideration
- taljethIs it even metadata? I think I'd call it something like cdi_pci_device_osdep when cdi_pci_device is the type that is "extended" by the struct
- pcmattmanWell, it could be information about the PCI device
- pcmattmanosdep works though, I'll change it
- taljethOk, thanks
- taljethI'll leave the rest of the comments to FreakyPenguin. It's getting late. ;-)
- taljethTalk to you tomorrow
- taljethOr rather this evening for you
- taljethGood night
- pcmattmanOkay, cya
- FreakyPenguingn8 taljeth ;-)
- pcmattmanThe patches are now on the list :)
- kwolfMoin
- DerHartmutMoin moin
- pcmattmanHi kwolf
- DerHartmutGood morning pcmattman
- DerHartmut-Good morning +Good evening
- pcmattmanMore patches on the list to review :)
- kwolfLooks like some work for the weekend :-)
- kwolfIf anyone wants to help me, you could review some of the patches and either comment on them or send your Acked-by
- DerHartmutI would do it, but I do not have any clue about CDI ^^
- quokHmm, anyone here want a google wave invite?